handmade.network » Forums » Site Feedback » Permalinks are not always right
mrmixer
Simon Anciaux
286 posts
#6812 [Resolved] Permalinks are not always right
1 year, 6 months ago Edited by Andrew Chronister on May 5, 2016, 7:23 a.m.

Page URL: https://handmade.network/forums/t/1124/2
Description of issue: If you click the permalink to a specific post, it doesn't bring you to that post. E.g. Clicking on the permalink for the post #6452 brings you to that page https://handmade.network/forums/t/1124/3#6452 which is the next page in the thread. Some of the links in the "Feedback Lists: Please README first" thread point you to the wrong place.
Browser + version: Firefox 46.0
Screenshot(s):
Miblo
Matt Mascarenhas
107 posts
2 projects

Annotator, supper gatherer and slammer of thunderous high fives

#6816 Permalinks are not always right
1 year, 6 months ago

Cheers, Simon. What seems to be happening is that it's basing the page calculations on the assumption that there are 10 posts per page, when in reality there are currently 15 posts per page. So, on page 1 of the megathread, the permalinks for posts 1–10 get mapped correctly, while those for posts 11–15 get mapped incorrectly to page 2. Then on page 2, posts 1–5 get mapped correctly, but 6–15 get mapped to page 3. From the top of page 3 onwards all of the mappings are off.
Kelimion
Jeroen van Rijn
240 posts
3 projects

A big ball of Wibbly-Wobbly, Timey-Wimey _stuff_

#6817 Permalinks are not always right
1 year, 6 months ago

Miblo
Cheers, Simon. What seems to be happening is that it's basing the page calculations on the assumption that there are 10 posts per page, when in reality there are currently 15 posts per page. So, on page 1 of the megathread, the permalinks for posts 1–10 get mapped correctly, while those for posts 11–15 get mapped incorrectly to page 2. Then on page 2, posts 1–5 get mapped correctly, but 6–15 get mapped to page 3. From the top of page 3 onwards all of the mappings are off.


That's true. Chronal changed the '# per page' bit of the pagination the other day, but hasn't seemed to have carried that through everywhere possibly?
ChronalDragon
Andrew Chronister
186 posts
2 projects

Developer, administrator, and style wrangler

#6827 Permalinks are not always right
1 year, 6 months ago

I've bumped the perpage number in the other place it was being used. Unless there's a third one lurking somewhere, this should be fixed.