handmade.network » Forums » Site Feedback » Thread list: going back to a specific page gives a wrong link
mrmixer
Simon Anciaux
286 posts
#6811 [Resolved] Thread list: going back to a specific page gives a wrong link
1 year, 6 months ago Edited by Andrew Chronister on May 5, 2016, 7:31 a.m.

Page URL: https://hero.handmade.network/forums/code-discussion/38
Description of issue: When in a forum with several pages, going to a page with a lower number (going from page 30 to page 29) create a wrong link.
Browser + version: Firefox 46.0
Screenshot(s): http://www.sisyphe.be/donotdelete/thread_list_link_bug.png (link at the bottom left of the screenshot)



Miblo
Matt Mascarenhas
107 posts
2 projects

Annotator, supper gatherer and slammer of thunderous high fives

#6815 Thread list: going back to a specific page gives a wrong link
1 year, 6 months ago Edited by Matt Mascarenhas on May 4, 2016, 7:54 p.m.

This seems to be related to this bug, I think, but I'll add a new entry in the "bug reports" list pointing to this thread.

Update: As far as I can tell, it seems to only affect sub-forums, whereas the previous bug affected handmade.network's "top-level" Forums.
ChronalDragon
Andrew Chronister
186 posts
2 projects

Developer, administrator, and style wrangler

#6828 Thread list: going back to a specific page gives a wrong link
1 year, 6 months ago Edited by Andrew Chronister on May 5, 2016, 7:31 a.m.

This is due to a stray comma probably introduced in the fix for the last bug. Fixed.

Side rant: Holy shit, a single comma in the source code producing a user-visible change like this is awful. We really need to get off of Django/Python, this would never fly in a compiled, strongly typed language. It's really stunning to me the series of bad decisions which allows that comma to propagate through to the final HTML.
</siderant>